Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Correct a test. The error message changed because, with this fix, we
detected (correctly) that there was only one impl and hence ignored the `Self` bound completely. I (semi-arbitrarily) elected to delect the impl, forcing the trait matcher to be more conservative and lean on the where clauses in scope, yielding the original error message.
- Loading branch information
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at nikomatsakis@f4a7d32
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nikomatsakis/rust/issue-18019 = f4a7d32 into auto
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nikomatsakis/rust/issue-18019 = f4a7d32 merged ok, testing candidate = b0c4728
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1488
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at nikomatsakis@f4a7d32
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nikomatsakis/rust/issue-18019 = f4a7d32 into auto
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nikomatsakis/rust/issue-18019 = f4a7d32 merged ok, testing candidate = 2fe96fd2
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1842
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1842
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1836
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1835
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1490
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1493
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at nikomatsakis@f4a7d32
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nikomatsakis/rust/issue-18019 = f4a7d32 into auto
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nikomatsakis/rust/issue-18019 = f4a7d32 merged ok, testing candidate = 7124b838
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/332
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at nikomatsakis@f4a7d32
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nikomatsakis/rust/issue-18019 = f4a7d32 into auto
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nikomatsakis/rust/issue-18019 = f4a7d32 merged ok, testing candidate = 2c0f876
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1849
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1848
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1841
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1848
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1842
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1841
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1841
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1845
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1839
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1838
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1841
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1496
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1496
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1499
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/336
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/337
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/328
f4a7d32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 2c0f876