Skip to content

Commit

Permalink
Remove unnecessary trait accessibility check.
Browse files Browse the repository at this point in the history
  • Loading branch information
Eljay committed Sep 18, 2015
1 parent fb5de8c commit f4f95eb
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/librustc_privacy/lib.rs
Expand Up @@ -847,12 +847,8 @@ impl<'a, 'tcx> PrivacyVisitor<'a, 'tcx> {
ty::ImplContainer(_) => {
self.check_static_method(span, method_def_id, name)
}
// Trait methods are always all public. The only controlling factor
// is whether the trait itself is accessible or not.
ty::TraitContainer(trait_def_id) => {
self.report_error(self.ensure_public(span, trait_def_id,
None, "source trait"));
}
// Trait methods are always accessible if the trait is in scope.
ty::TraitContainer(_) => {}
}
}
}
Expand Down
27 changes: 27 additions & 0 deletions src/test/run-pass/issue-16264.rs
@@ -0,0 +1,27 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

use outer::Foo;

mod outer {
pub use self::inner::Foo;

mod inner {
pub trait Foo {
fn bar(&self) {}
}
impl Foo for i32 {}
}
}

fn main() {
let x: i32 = 0;
x.bar();
}

0 comments on commit f4f95eb

Please sign in to comment.