Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Currently when a read-only file has unlink() invoked on it on windows, the call will fail. On unix, however, the call will succeed. In order to have a more consistent behavior across platforms, this error is recognized on windows and the file is changed to read-write before removal is attempted.
- Loading branch information
1 parent
996263a
commit fe67d26
Showing
3 changed files
with
47 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe67d26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@fe67d26
fe67d26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/windows-unlink = fe67d26 into auto
fe67d26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/windows-unlink = fe67d26 merged ok, testing candidate = 482f53a6
fe67d26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/333
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/329
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/330
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/329
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/330
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/332
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/333
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/332
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/338
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/333
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/332
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/335
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/333
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/334
fe67d26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@fe67d26
fe67d26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/windows-unlink = fe67d26 into auto
fe67d26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/windows-unlink = fe67d26 merged ok, testing candidate = b733592
fe67d26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/330
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/331
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/330
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/331
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/333
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/334
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/333
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/339
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/334
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/333
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/336
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/334
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/334
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/335
fe67d26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = b733592