Generate GetConstructorObject for all interfaces

servo · Jun 13, 2017 · 0713257 · 0713257
1 parent 147dfcc
commit 0713257
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py
@@ -2863,7 +2863,7 @@ def definition_body(self):
                                     %(length)s,
                                     interface.handle_mut());
 assert!(!interface.is_null());""" % properties))
-            if self.descriptor.hasDescendants():
+            if self.descriptor.shouldCacheConstructor():
                 code.append(CGGeneric("""\
 assert!((*cache)[PrototypeList::Constructor::%(id)s as usize].is_null());
 (*cache)[PrototypeList::Constructor::%(id)s as usize] = interface.get();

diff --git a/components/script/dom/bindings/codegen/Configuration.py b/components/script/dom/bindings/codegen/Configuration.py
@@ -398,7 +398,11 @@ def shouldHaveGetConstructorObjectMethod(self):
         assert self.interface.hasInterfaceObject()
         if self.interface.getExtendedAttribute("Inline"):
             return False
-        return self.interface.isCallback() or self.interface.isNamespace() or self.hasDescendants()
+        return (self.interface.isCallback() or self.interface.isNamespace() or
+                self.hasDescendants() or self.interface.getExtendedAttribute("HTMLConstructor"))
+
+    def shouldCacheConstructor(self):
+        return self.hasDescendants() or self.interface.getExtendedAttribute("HTMLConstructor")
 
     def isExposedConditionally(self):
         return self.interface.isExposedConditionally()