Make sure we do not skip the HaveMetadata state. Fixes a bunch of tests

servo · Oct 8, 2018 · 11ac049 · 11ac049
1 parent 6b0acc9
commit 11ac049
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 0 deletions.
diff --git a/components/script/dom/htmlmediaelement.rs b/components/script/dom/htmlmediaelement.rs
@@ -1314,6 +1314,11 @@ impl FetchResponseListener for HTMLMediaElementContext {
         }
 
         if status.is_ok() {
+            if elem.ready_state.get() == ReadyState::HaveNothing {
+                // Make sure that we don't skip the HaveMetadata and HaveCurrentData
+                // states for short streams.
+                elem.change_ready_state(ReadyState::HaveMetadata);
+            }
             elem.change_ready_state(ReadyState::HaveEnoughData);
 
             elem.upcast::<EventTarget>().fire_event(atom!("progress"));

diff --git a/...edded-content/media-elements/loading-the-media-resource/load-events-networkState.html.ini b/...edded-content/media-elements/loading-the-media-resource/load-events-networkState.html.ini
@@ -0,0 +1,4 @@
+[load-events-networkState.html]
+  [NETWORK_NO_SOURCE]
+    expected: FAIL
+
diff --git a/...elements/loading-the-media-resource/resource-selection-invoke-insert-into-iframe.html.ini b/...elements/loading-the-media-resource/resource-selection-invoke-insert-into-iframe.html.ini
@@ -0,0 +1,4 @@
+[resource-selection-invoke-insert-into-iframe.html]
+  [NOT invoking resource selection by inserting into other document with src set]
+    expected: FAIL
+
diff --git a/...elements/loading-the-media-resource/resource-selection-invoke-pause-networkState.html.ini b/...elements/loading-the-media-resource/resource-selection-invoke-pause-networkState.html.ini
@@ -0,0 +1,4 @@
+[resource-selection-invoke-pause-networkState.html]
+  [NOT invoking resource selection with pause() when networkState is not NETWORK_EMPTY]
+    expected: FAIL
+
diff --git a/...g-the-media-resource/resource-selection-invoke-remove-from-document-networkState.html.ini b/...g-the-media-resource/resource-selection-invoke-remove-from-document-networkState.html.ini
@@ -0,0 +1,4 @@
+[resource-selection-invoke-remove-from-document-networkState.html]
+  [NOT invoking resource selection with implicit pause() when networkState is not NETWORK_EMPTY]
+    expected: FAIL
+