Skip to content

Commit

Permalink
Add some comments to may_generate_pseudo; no real behavior changes fo…
Browse files Browse the repository at this point in the history
…r now.

Gecko bug 1324618 part 2: https://bugzilla.mozilla.org/show_bug.cgi?id=1324618
  • Loading branch information
bzbarsky committed Jun 27, 2017
1 parent acb27de commit 18ab008
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion components/style/dom.rs
Expand Up @@ -426,9 +426,19 @@ pub trait TElement : Eq + PartialEq + Debug + Hash + Sized + Copy + Clone +
/// TODO(emilio, bz): actually implement the logic for it.
fn may_generate_pseudo(
&self,
_pseudo: &PseudoElement,
pseudo: &PseudoElement,
_primary_style: &ComputedValues,
) -> bool {
// ::before/::after are always supported for now, though we could try to
// optimize out leaf elements.

// ::first-letter and ::first-line are only supported for block-inside
// things, and only in Gecko, not Servo. Unfortunately, Gecko has
// block-inside things that might have any computed display value due to
// things like fieldsets, legends, etc. Need to figure out how this
// should work.
debug_assert!(pseudo.is_eager(),
"Someone called may_generate_pseudo with a non-eager pseudo.");
true
}

Expand Down

0 comments on commit 18ab008

Please sign in to comment.