Skip to content

Commit

Permalink
Fix assertion trying to remove a Node that has no parent
Browse files Browse the repository at this point in the history
fixes #4562
  • Loading branch information
Swatinem committed Jan 9, 2015
1 parent d9751c0 commit 322dacc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions components/script/dom/node.rs
Expand Up @@ -1478,6 +1478,7 @@ impl Node {
// Step 1.
match child.parent_node() {
Some(ref node) if node != &Temporary::from_rooted(parent) => return Err(NotFound),
None => return Err(NotFound),
_ => ()
}

Expand Down

5 comments on commit 322dacc

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from Ms2ger
at Swatinem@322dacc

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging Swatinem/servo/noderemove = 322dacc into auto

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swatinem/servo/noderemove = 322dacc merged ok, testing candidate = c338dbe

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = c338dbe

Please sign in to comment.