Skip to content

Commit

Permalink
Format support/hololens/
Browse files Browse the repository at this point in the history
  • Loading branch information
paulrouget committed Nov 4, 2019
1 parent 70823e3 commit 36c1669
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 25 deletions.
2 changes: 1 addition & 1 deletion python/servo/testing_commands.py
Expand Up @@ -810,7 +810,7 @@ def setup_clangfmt(all_files):
return False, None, None
gitcmd = ['git', 'ls-files']
if not all_files:
gitcmd.append('-m')
gitcmd.append('-m')
gitfiles = subprocess.check_output(gitcmd + CLANGFMT_CPP_DIRS).splitlines()
filtered = [line for line in gitfiles if line.endswith(".h") or line.endswith(".cpp")]
return True, cmd, filtered
Expand Down
2 changes: 1 addition & 1 deletion support/hololens/ServoApp/BrowserPage.cpp
Expand Up @@ -69,7 +69,7 @@ void BrowserPage::SetTransientMode(bool transient) {
navigationBar().Visibility(transient ? Visibility::Collapsed
: Visibility::Visible);
transientLoadingIndicator().Visibility(transient ? Visibility::Visible
: Visibility::Collapsed);
: Visibility::Collapsed);
}

void BrowserPage::SetArgs(hstring args) { servoControl().SetArgs(args); }
Expand Down
33 changes: 17 additions & 16 deletions support/hololens/ServoApp/ServoControl/Servo.cpp
Expand Up @@ -47,17 +47,17 @@ void on_ime_state_changed(bool aShow) {
sServo->Delegate().OnServoIMEStateChanged(aShow);
}

void set_clipboard_contents(const char* content) {
void set_clipboard_contents(const char *content) {
// FIXME
}

const char* get_clipboard_contents() {
const char *get_clipboard_contents() {
// FIXME
return nullptr;
}

Servo::Servo(hstring url, hstring args, GLsizei width, GLsizei height, float dpi,
ServoDelegate &aDelegate)
Servo::Servo(hstring url, hstring args, GLsizei width, GLsizei height,
float dpi, ServoDelegate &aDelegate)
: mWindowHeight(height), mWindowWidth(width), mDelegate(aDelegate) {

capi::CInitOptions o;
Expand All @@ -73,22 +73,23 @@ Servo::Servo(hstring url, hstring args, GLsizei width, GLsizei height, float dpi
// 7 filter modules.
/* Sample list of servo modules to filter.
static char *pfilters[] = {
"servo",
"simpleservo",
"simpleservo::jniapi",
"simpleservo::gl_glue::egl",
// Show JS errors by default.
"script::dom::bindings::error",
// Show GL errors by default.
"canvas::webgl_thread",
"compositing::compositor",
"constellation::constellation",
"servo",
"simpleservo",
"simpleservo::jniapi",
"simpleservo::gl_glue::egl",
// Show JS errors by default.
"script::dom::bindings::error",
// Show GL errors by default.
"canvas::webgl_thread",
"compositing::compositor",
"constellation::constellation",
};
*/

// Example Call when *pfilters[] is used:
// o.vslogger_mod_list = pfilters; // servo log modules
// o.vslogger_mod_size = sizeof(pfilters) / sizeof(pfilters[0]) -1; // Important: Number of modules in pfilters
// o.vslogger_mod_size = sizeof(pfilters) / sizeof(pfilters[0]) -1; //
// Important: Number of modules in pfilters
o.vslogger_mod_list = NULL;
o.vslogger_mod_size = 0;

Expand Down Expand Up @@ -135,7 +136,7 @@ std::unique_ptr<char *> hstring2char(hstring hstr) {
char *str = new char[size];
size_t converted = 0;
wcstombs_s(&converted, str, size, wc, hstr.size());
return std::make_unique<char*>(str);
return std::make_unique<char *>(str);
}

} // namespace winrt::servo
4 changes: 2 additions & 2 deletions support/hololens/ServoApp/ServoControl/ServoControl.cpp
Expand Up @@ -203,8 +203,8 @@ void ServoControl::Loop() {
if (mServo == nullptr) {
log("Entering loop");
ServoDelegate *sd = static_cast<ServoDelegate *>(this);
mServo = std::make_unique<Servo>(mInitialURL, mArgs, panelWidth, panelHeight, mDPI,
*sd);
mServo = std::make_unique<Servo>(mInitialURL, mArgs, panelWidth,
panelHeight, mDPI, *sd);
} else {
// FIXME: this will fail since create_task didn't pick the thread
// where Servo was running initially.
Expand Down
10 changes: 5 additions & 5 deletions support/hololens/ServoApp/ServoControl/ServoControl.h
Expand Up @@ -118,12 +118,12 @@ struct ServoControl : ServoControlT<ServoControl>, public servo::ServoDelegate {
}
}

void
OnSurfaceTapped(IInspectable const &,
Windows::UI::Xaml::Input::TappedRoutedEventArgs const &);
void OnSurfaceTapped(IInspectable const &,
Windows::UI::Xaml::Input::TappedRoutedEventArgs const &);

void OnSurfacePointerPressed(IInspectable const &,
Windows::UI::Xaml::Input::PointerRoutedEventArgs const &);
void OnSurfacePointerPressed(
IInspectable const &,
Windows::UI::Xaml::Input::PointerRoutedEventArgs const &);

void OnSurfaceManipulationDelta(
IInspectable const &,
Expand Down

0 comments on commit 36c1669

Please sign in to comment.