Skip to content

Commit

Permalink
Don't generate rare_data_for_layout methods anymore
Browse files Browse the repository at this point in the history
It is only used twice.
  • Loading branch information
nox committed Mar 31, 2020
1 parent dd750c6 commit 414d477
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
5 changes: 3 additions & 2 deletions components/script/dom/element.rs
Expand Up @@ -1039,8 +1039,9 @@ impl<'dom> LayoutElementHelpers<'dom> for LayoutDom<'dom, Element> {
#[inline]
#[allow(unsafe_code)]
unsafe fn get_shadow_root_for_layout(self) -> Option<LayoutDom<'dom, ShadowRoot>> {
(*self.unsafe_get())
.rare_data_for_layout()
self.unsafe_get()
.rare_data
.borrow_for_layout()
.as_ref()?
.shadow_root
.as_ref()
Expand Down
5 changes: 0 additions & 5 deletions components/script/dom/macros.rs
Expand Up @@ -671,11 +671,6 @@ macro_rules! impl_rare_data (
rare_data.as_mut().unwrap()
})
}

#[allow(unsafe_code)]
fn rare_data_for_layout(&self) -> &Option<Box<$type>> {
unsafe { self.rare_data.borrow_for_layout() }
}
);
);

Expand Down
5 changes: 3 additions & 2 deletions components/script/dom/node.rs
Expand Up @@ -1400,8 +1400,9 @@ impl<'dom> LayoutNodeHelpers<'dom> for LayoutDom<'dom, Node> {
#[inline]
#[allow(unsafe_code)]
unsafe fn containing_shadow_root_for_layout(self) -> Option<LayoutDom<'dom, ShadowRoot>> {
(*self.unsafe_get())
.rare_data_for_layout()
self.unsafe_get()
.rare_data
.borrow_for_layout()
.as_ref()?
.containing_shadow_root
.as_ref()
Expand Down

0 comments on commit 414d477

Please sign in to comment.