Add some FIXME comments about using ptr::NonNull

servo · Jan 22, 2018 · 4be3096 · 4be3096
1 parent b78ac6b
commit 4be3096
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/components/hashglobe/src/shim.rs b/components/hashglobe/src/shim.rs
@@ -1,5 +1,6 @@
 use std::marker::PhantomData;
 
+// FIXME: remove this and use std::ptr::NonNull when Firefox requires Rust 1.25+
 pub struct NonZeroPtr<T: 'static>(&'static T);
 
 impl<T: 'static> NonZeroPtr<T> {
@@ -57,4 +58,4 @@ impl<'a, T> From<&'a mut T> for Shared<T> {
     fn from(reference: &'a mut T) -> Self {
         unsafe { Shared::new_unchecked(reference) }
     }
-}
+}
diff --git a/components/servo_arc/lib.rs b/components/servo_arc/lib.rs
@@ -83,6 +83,7 @@ const MAX_REFCOUNT: usize = (isize::MAX) as usize;
 /// that this is all a temporary hack, this restriction is fine for now.
 ///
 /// [1]: https://github.com/rust-lang/rust/issues/27730
+// FIXME: remove this and use std::ptr::NonNull when Firefox requires Rust 1.25+
 pub struct NonZeroPtrMut<T: ?Sized + 'static>(&'static mut T);
 impl<T: ?Sized> NonZeroPtrMut<T> {
     pub fn new(ptr: *mut T) -> Self {

diff --git a/components/style/rule_tree/mod.rs b/components/style/rule_tree/mod.rs
@@ -828,6 +828,8 @@ impl MallocSizeOf for RuleNode {
     }
 }
 
+// FIXME: use std::ptr::NonNull when Firefox requires Rust 1.25+
+
 #[derive(Clone)]
 struct WeakRuleNode {
     p: NonZeroPtrMut<RuleNode>,