Skip to content

Commit

Permalink
style: paint-order parsing has off-by-one error.
Browse files Browse the repository at this point in the history
A couple of firefox only WPT failure caused by this off-by-one bug.

Differential Revision: https://phabricator.services.mozilla.com/D35630
  • Loading branch information
violette77 authored and emilio committed Jul 8, 2019
1 parent 2fba62a commit 5db88db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/style/values/specified/svg.rs
Expand Up @@ -200,7 +200,7 @@ impl Parse for SVGPaintOrder {

// fill in rest
for i in pos..PAINT_ORDER_COUNT {
for paint in 0..PAINT_ORDER_COUNT {
for paint in 1..(PAINT_ORDER_COUNT + 1) {
// if not seen, set bit at position, mark as seen
if (seen & (1 << paint)) == 0 {
seen |= 1 << paint;
Expand Down

0 comments on commit 5db88db

Please sign in to comment.