Expose TextTrack.activeCues

servo · Jan 11, 2019 · 69a79c7 · 69a79c7
1 parent 2a78625
commit 69a79c7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/components/script/dom/texttrack.rs b/components/script/dom/texttrack.rs
@@ -110,6 +110,13 @@ impl TextTrackMethods for TextTrack {
         }
     }
 
+    // https://html.spec.whatwg.org/multipage/#dom-texttrack-activecues
+    fn GetActiveCues(&self) -> Option<DomRoot<TextTrackCueList>> {
+        // XXX implement active cues logic
+        //      https://github.com/servo/servo/issues/22314
+        None
+    }
+
     // https://html.spec.whatwg.org/multipage/#dom-texttrack-addcue
     fn AddCue(&self, cue: &TextTrackCue) -> ErrorResult {
         // FIXME(#22314, dlrobertson) add Step 1 & 2

diff --git a/components/script/dom/webidls/TextTrack.webidl b/components/script/dom/webidls/TextTrack.webidl
@@ -19,7 +19,7 @@ interface TextTrack : EventTarget {
   attribute TextTrackMode mode;
 
   readonly attribute TextTrackCueList? cues;
-  // readonly attribute TextTrackCueList? activeCues;
+  readonly attribute TextTrackCueList? activeCues;
 
   [Throws]
   void addCue(TextTrackCue cue);

diff --git a/tests/wpt/metadata/html/dom/interfaces.https.html.ini b/tests/wpt/metadata/html/dom/interfaces.https.html.ini
@@ -9563,15 +9563,9 @@
   [TextTrack interface: attribute inBandMetadataTrackDispatchType]
     expected: FAIL
 
-  [TextTrack interface: attribute activeCues]
-    expected: FAIL
-
   [TextTrack interface: document.createElement("track").track must inherit property "inBandMetadataTrackDispatchType" with the proper type]
     expected: FAIL
 
-  [TextTrack interface: document.createElement("track").track must inherit property "activeCues" with the proper type]
-    expected: FAIL
-
   [TimeRanges must be primary interface of document.createElement("video").buffered]
     expected: FAIL