Skip to content

Commit

Permalink
HACK: don't call media_source_failure_steps when eos
Browse files Browse the repository at this point in the history
Because gstreamer's appsrc queue might be big enough to swallow
the whole video holding the metadata extraction until EOS.
  • Loading branch information
ceyusa authored and ferjm committed Oct 8, 2018
1 parent ce76b57 commit 77c7eda
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions components/script/dom/htmlmediaelement.rs
Expand Up @@ -1138,8 +1138,8 @@ impl FetchResponseListener for HTMLMediaElementContext {
// format, or can otherwise not be rendered at all"
if !elem.have_metadata.get() {
// FIXME(victor): adjust player's max-size (or buffering)
elem.queue_dedicated_media_source_failure_steps();
// => "Once the entire media resource has been fetched..."
//elem.queue_dedicated_media_source_failure_steps();
// => "Once the entire media resource has been fetched..."
} else if status.is_ok() {
elem.change_ready_state(ReadyState::HaveEnoughData);

Expand Down

0 comments on commit 77c7eda

Please sign in to comment.