Skip to content

Commit

Permalink
Fix warning in scroll root id assignment to TableColGroupFlow
Browse files Browse the repository at this point in the history
The traversal currently expects every flow to have a scroll root id
assigned, even if it doesn't produce any display items. This change
fixes the error that arises from this situation.
  • Loading branch information
mrobinson committed Aug 3, 2017
1 parent 3c28c7b commit 815ed0c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion components/layout/table_colgroup.rs
Expand Up @@ -92,7 +92,11 @@ impl Flow for TableColGroupFlow {
// Table columns are invisible.
fn build_display_list(&mut self, _: &mut DisplayListBuildState) { }

fn collect_stacking_contexts(&mut self, _: &mut DisplayListBuildState) {}
fn collect_stacking_contexts(&mut self, state: &mut DisplayListBuildState) {
self.base.stacking_context_id = state.current_stacking_context_id;
self.base.scroll_root_id = Some(state.current_scroll_root_id);
}


fn repair_style(&mut self, _: &::ServoArc<ComputedValues>) {}

Expand Down

0 comments on commit 815ed0c

Please sign in to comment.