Fix char types in script binding codegen

Use `libc::c_char` instead of `i8` for character data since that's more portable. (Some architectures, e.g. AArch64, have unsigned characters, i.e. `u8`.)
servo · Oct 21, 2015 · 8405ac7 · 8405ac7
1 parent 7fb3c51
commit 8405ac7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py
@@ -1437,12 +1437,12 @@ def specData(m):
             # TODO: Use something like JS_FNSPEC
             # https://github.com/servo/servo/issues/6391
             if "selfHostedName" in m:
-                selfHostedName = '%s as *const u8 as *const i8' % str_to_const_array(m["selfHostedName"])
+                selfHostedName = '%s as *const u8 as *const libc::c_char' % str_to_const_array(m["selfHostedName"])
                 assert not m.get("methodInfo", True)
                 accessor = "None"
                 jitinfo = "0 as *const JSJitInfo"
             else:
-                selfHostedName = "0 as *const i8"
+                selfHostedName = "0 as *const libc::c_char"
                 if m.get("methodInfo", True):
                     identifier = m.get("nativeName", m["name"])
                     jitinfo = "&%s_methodinfo" % identifier
@@ -1469,7 +1469,7 @@ def specData(m):
             '        call: JSNativeWrapper { op: None, info: 0 as *const JSJitInfo },\n'
             '        nargs: 0,\n'
             '        flags: 0,\n'
-            '        selfHostedName: 0 as *const i8\n'
+            '        selfHostedName: 0 as *const libc::c_char\n'
             '    }',
             'JSFunctionSpec',
             specData)