Implement the target attribute for HTMLAreaElement

servo · Feb 11, 2019 · 90b5d0d · 90b5d0d
1 parent 71ba247
commit 90b5d0d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 14 deletions.
diff --git a/components/script/dom/htmlareaelement.rs b/components/script/dom/htmlareaelement.rs
@@ -299,6 +299,12 @@ impl VirtualMethods for HTMLAreaElement {
 }
 
 impl HTMLAreaElementMethods for HTMLAreaElement {
+    // https://html.spec.whatwg.org/multipage/#attr-hyperlink-target
+    make_getter!(Target, "target");
+
+    // https://html.spec.whatwg.org/multipage/#attr-hyperlink-target
+    make_setter!(SetTarget, "target");
+
     // https://html.spec.whatwg.org/multipage/#dom-area-rellist
     fn RelList(&self) -> DomRoot<DOMTokenList> {
         self.rel_list

diff --git a/components/script/dom/webidls/HTMLAreaElement.webidl b/components/script/dom/webidls/HTMLAreaElement.webidl
@@ -11,8 +11,8 @@ interface HTMLAreaElement : HTMLElement {
   //         attribute DOMString coords;
   // [CEReactions]
   //         attribute DOMString shape;
-  // [CEReactions]
-  //         attribute DOMString target;
+  [CEReactions]
+             attribute DOMString target;
   // [CEReactions]
   //         attribute DOMString download;
   // [CEReactions]

diff --git a/tests/wpt/metadata/html/dom/interfaces.https.html.ini b/tests/wpt/metadata/html/dom/interfaces.https.html.ini
@@ -1898,9 +1898,6 @@
   [HTMLAreaElement interface: attribute shape]
     expected: FAIL
 
-  [HTMLAreaElement interface: attribute target]
-    expected: FAIL
-
   [HTMLAreaElement interface: attribute download]
     expected: FAIL
 
@@ -1964,9 +1961,6 @@
   [HTMLAreaElement interface: document.createElement("area") must inherit property "shape" with the proper type]
     expected: FAIL
 
-  [HTMLAreaElement interface: document.createElement("area") must inherit property "target" with the proper type]
-    expected: FAIL
-
   [HTMLAreaElement interface: document.createElement("area") must inherit property "download" with the proper type]
     expected: FAIL
 
@@ -6912,9 +6906,6 @@
   [HTMLAreaElement interface: attribute shape]
     expected: FAIL
 
-  [HTMLAreaElement interface: attribute target]
-    expected: FAIL
-
   [HTMLAreaElement interface: attribute download]
     expected: FAIL
 
@@ -6978,9 +6969,6 @@
   [HTMLAreaElement interface: document.createElement("area") must inherit property "shape" with the proper type]
     expected: FAIL
 
-  [HTMLAreaElement interface: document.createElement("area") must inherit property "target" with the proper type]
-    expected: FAIL
-
   [HTMLAreaElement interface: document.createElement("area") must inherit property "download" with the proper type]
     expected: FAIL