Skip to content

Commit

Permalink
Rename decision-task.py to make it importable
Browse files Browse the repository at this point in the history
  • Loading branch information
SimonSapin committed Oct 9, 2018
1 parent 545d547 commit 9515028
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .taskcluster.yml
Expand Up @@ -53,4 +53,4 @@ tasks:
cd repo &&
git fetch --depth 1 "$GIT_URL" "$GIT_REF" &&
git reset --hard "$GIT_SHA" &&
python3 etc/taskcluster/decision-task.py
python3 etc/taskcluster/decision_task.py
8 changes: 4 additions & 4 deletions etc/taskcluster/README.md
Expand Up @@ -40,7 +40,7 @@ to build an arbitrary [task graph].
## Servo’s decision task

This repository’s [`.taskcluster.yml`][tc.yml] schedules a single task
that runs the Python 3 script [`etc/taskcluster/decision-task.py`](decision-task.py).
that runs the Python 3 script [`etc/taskcluster/decision_task.py`](decision_task.py).
It is called a *decision task* as it is responsible for deciding what other tasks to schedule.

The Docker image that runs the decision task
Expand Down Expand Up @@ -101,7 +101,7 @@ together with multiple testing tasks that each depend on the build task
(wait until it successfully finishes before they can start)
and start by downloading the artifact that was saved earlier.

The logic for all this is in [`decision-task.py`](decision-task.py)
The logic for all this is in [`decision_task.py`](decision_task.py)
and can be modified in any pull request.

[web-platform-tests]: https://github.com/web-platform-tests/wpt
Expand Down Expand Up @@ -162,7 +162,7 @@ to edit that role in the web UI and grant more scopes to these tasks
The [`project-servo/daily`] hook in Taskcluster’s [Hooks service]
is used to run some tasks automatically ever 24 hours.
In this case as well we use a decision task.
The `decision-task.py` script can differenciate this from a GitHub push
The `decision_task.py` script can differenciate this from a GitHub push
based on the `$TASK_FOR` environment variable.
Daily tasks can also be triggered manually.

Expand Down Expand Up @@ -221,7 +221,7 @@ To modify those, submit a pull request.

* The [`.taskcluster.yml`][tc.yml] file,
for starting decision tasks in reaction to GitHub events
* The [`etc/ci/decision-task.py`](decision-task.py) file,
* The [`etc/ci/decision_task.py`](decision_task.py) file,
defining what other tasks to schedule

However some configuration needs to be handled separately.
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion servo-tidy.toml
Expand Up @@ -69,7 +69,7 @@ files = [
"./tests/wpt/mozilla/tests/css/pre_with_tab.html",
"./tests/wpt/mozilla/tests/mozilla/textarea_placeholder.html",
# Python 3 syntax causes "E901 SyntaxError" when flake8 runs in Python 2
"./etc/taskcluster/decision-task.py",
"./etc/taskcluster/decision_task.py",
"./etc/taskcluster/decisionlib.py",
]
# Directories that are ignored for the non-WPT tidy check.
Expand Down

0 comments on commit 9515028

Please sign in to comment.