Handle setting selectionStart to be > selectionEnd

servo · Nov 25, 2017 · 9b06cb3 · 9b06cb3
1 parent 95a7e09
commit 9b06cb3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/components/script/dom/textcontrol.rs b/components/script/dom/textcontrol.rs
@@ -21,7 +21,16 @@ pub trait TextControl: DerivedFrom<EventTarget> + DerivedFrom<Node> {
 
     // https://html.spec.whatwg.org/multipage/#dom-textarea/input-selectionstart
     fn set_dom_selection_start(&self, start: u32) {
-        self.set_selection_range(start, self.dom_selection_end(), self.selection_direction());
+        // Step 2
+        let mut end = self.dom_selection_end();
+
+        // Step 3
+        if end < start {
+            end = start;
+        }
+
+        // Step 4
+        self.set_selection_range(start, end, self.selection_direction());
     }
 
     // https://html.spec.whatwg.org/multipage/#dom-textarea/input-selectionend

diff --git a/tests/wpt/metadata/html/semantics/forms/textfieldselection/selection-start-end.html.ini b/tests/wpt/metadata/html/semantics/forms/textfieldselection/selection-start-end.html.ini