Skip to content

Commit

Permalink
Make tidy.py check for links to spec pages. [Issue#5730]
Browse files Browse the repository at this point in the history
  • Loading branch information
JayNakrani committed Apr 21, 2015
1 parent a3dafe4 commit a0295b7
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion python/tidy.py
Expand Up @@ -12,6 +12,7 @@
import os
import fnmatch
import itertools
import re
from licenseck import licenses

directories_to_check = ["ports", "components", "tests"]
Expand Down Expand Up @@ -72,6 +73,15 @@ def check_length(contents):
if len(line) >= 160:
yield (idx + 1, "(much) overlong line")

def check_whatwg_url(contents):
lines = contents.splitlines(True)
for idx, line in enumerate(lines):
matches = re.findall(r'whatwg.org/multipage.*#', line);
if matches:
for i, match in enumerate(matches):
parts = match.split('multipage')
if len(parts[1]) > 1 and parts[1][1] != '#':
yield (idx + 1, "URL should not point to specific WHATWG multipage page!")

def check_whitespace(contents):
lines = contents.splitlines(True)
Expand Down Expand Up @@ -127,7 +137,7 @@ def scan():
all_files = collect_file_names(directories_to_check)
files_to_check = filter(should_check, all_files)

checking_functions = [check_license, check_length, check_whitespace]
checking_functions = [check_license, check_length, check_whitespace, check_whatwg_url]
errors = collect_errors_for_files(files_to_check, checking_functions)

reftest_files = collect_file_names(reftest_directories)
Expand Down

0 comments on commit a0295b7

Please sign in to comment.