Skip to content

Commit

Permalink
Ensure that position_fixed reftest matches ahem font requirements.
Browse files Browse the repository at this point in the history
The ahem font should always be a multiple of 5px and a minimum size
of 20px for reliable results [1]. In particular, on some macs, using
the default size of 16 results in a reported metric of 16 x 17 from
the OS. This is currently working, but breaks when WR is updated to
do pixel snapping in world space.

[1] http://testthewebforward.org/docs/test-style-guidelines.html#special-fonts
  • Loading branch information
gw3583 committed Feb 13, 2017
1 parent e985ad5 commit afc6a2b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/wpt/mozilla/meta/MANIFEST.json
Expand Up @@ -22977,11 +22977,11 @@
"support"
],
"css/position_fixed_a.html": [
"e0cec72521c5ad893c260f7d0f3542d1464161e9",
"afbcc31b0460931d7ed8a2fdc1399d2f84fe33d5",
"reftest"
],
"css/position_fixed_b.html": [
"4a4589634026999bbb40d0cb92c114e7af4ad61a",
"251a490233a7836accc5883093a765f88e6006b5",
"support"
],
"css/position_fixed_background_color_a.html": [
Expand Down
1 change: 1 addition & 0 deletions tests/wpt/mozilla/tests/css/position_fixed_a.html
Expand Up @@ -13,6 +13,7 @@
because test reference depends on dynamic sizing, and different
fonts change the required margins. */
font-family: 'Ahem';
font-size: 20px;
}
.fixed_block {
background: green;
Expand Down
1 change: 1 addition & 0 deletions tests/wpt/mozilla/tests/css/position_fixed_b.html
Expand Up @@ -9,6 +9,7 @@
background: blue;

font-family: 'Ahem';
font-size: 20px;
}
div {
position: absolute;
Expand Down

0 comments on commit afc6a2b

Please sign in to comment.