Skip to content

Commit

Permalink
Implement ./mach doc --media-stack={dummy|gstreamer}
Browse files Browse the repository at this point in the history
  • Loading branch information
Tuncer Ayaz committed Nov 21, 2019
1 parent 01a99b5 commit ba3169e
Showing 1 changed file with 22 additions and 1 deletion.
23 changes: 22 additions & 1 deletion python/servo/post_build_commands.py
Expand Up @@ -238,8 +238,13 @@ def rr_replay(self):
@CommandArgument(
'params', nargs='...',
help="Command-line arguments to be passed through to cargo doc")
@CommandArgument('--media-stack',
default=None,
choices=["gstreamer", "dummy"],
help='Which media stack to use')
@CommandBase.build_like_command_arguments
def doc(self, params, features, **kwargs):
def doc(self, params, features, target=None, android=False, magicleap=False,
media_stack=None, **kwargs):
env = os.environ.copy()
env["RUSTUP_TOOLCHAIN"] = self.toolchain()
rustc_path = check_output(["rustup" + BIN_SUFFIX, "which", "rustc"], env=env)
Expand Down Expand Up @@ -268,6 +273,22 @@ def doc(self, params, features, **kwargs):
copy2(full_name, destination)

features = features or []

target, android = self.pick_target_triple(target, android, magicleap)

# A guess about which platforms should use the gstreamer media stack
if not(media_stack):
if (
not(target) or
("armv7" in target and "android" in target) or
("x86_64" in target)
):
media_stack = "gstreamer"
else:
media_stack = "dummy"

features += ["media-" + media_stack]

returncode = self.run_cargo_build_like_command("doc", params, features=features, **kwargs)
if returncode:
return returncode
Expand Down

0 comments on commit ba3169e

Please sign in to comment.