Implement the unitless length quirk for margin-*

servo · Apr 27, 2017 · bcc6d45 · bcc6d45
1 parent 72186c2
commit bcc6d45
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 54 deletions.
diff --git a/components/style/properties/longhand/margin.mako.rs b/components/style/properties/longhand/margin.mako.rs
@@ -15,6 +15,7 @@
     ${helpers.predefined_type("margin-%s" % side[0], "LengthOrPercentageOrAuto",
                               "computed::LengthOrPercentageOrAuto::Length(Au(0))",
                               alias=maybe_moz_logical_alias(product, side, "-moz-margin-%s"),
+                              allow_quirks=not side[1],
                               animation_value_type="ComputedValue", logical = side[1], spec = spec,
                               allowed_in_page_rule=True)}
 % endfor
diff --git a/tests/wpt/metadata/quirks-mode/unitless-length.html.ini b/tests/wpt/metadata/quirks-mode/unitless-length.html.ini
@@ -12,15 +12,6 @@
     expected:
       if os == "mac": FAIL
 
-  [margin-left: 1 (quirks)]
-    expected: FAIL
-
-  [margin-top: 1 (quirks)]
-    expected: FAIL
-
-  [margin-bottom: 1 (quirks)]
-    expected: FAIL
-
   [margin: 1 (quirks)]
     expected: FAIL
 
@@ -84,15 +75,6 @@
     expected:
       if os == "mac": FAIL
 
-  [margin-left: +1 (quirks)]
-    expected: FAIL
-
-  [margin-top: +1 (quirks)]
-    expected: FAIL
-
-  [margin-bottom: +1 (quirks)]
-    expected: FAIL
-
   [margin: +1 (quirks)]
     expected: FAIL
 
@@ -156,15 +138,6 @@
     expected:
       if os == "mac": FAIL
 
-  [margin-left: -1 (quirks)]
-    expected: FAIL
-
-  [margin-top: -1 (quirks)]
-    expected: FAIL
-
-  [margin-bottom: -1 (quirks)]
-    expected: FAIL
-
   [margin: -1 (quirks)]
     expected: FAIL
 
@@ -204,15 +177,6 @@
     expected:
       if os == "mac": FAIL
 
-  [margin-left: 1.5 (quirks)]
-    expected: FAIL
-
-  [margin-top: 1.5 (quirks)]
-    expected: FAIL
-
-  [margin-bottom: 1.5 (quirks)]
-    expected: FAIL
-
   [margin: 1.5 (quirks)]
     expected: FAIL
 
@@ -276,15 +240,6 @@
     expected:
       if os == "mac": FAIL
 
-  [margin-left: +1.5 (quirks)]
-    expected: FAIL
-
-  [margin-top: +1.5 (quirks)]
-    expected: FAIL
-
-  [margin-bottom: +1.5 (quirks)]
-    expected: FAIL
-
   [margin: +1.5 (quirks)]
     expected: FAIL
 
@@ -348,15 +303,6 @@
     expected:
       if os == "mac": FAIL
 
-  [margin-left: -1.5 (quirks)]
-    expected: FAIL
-
-  [margin-top: -1.5 (quirks)]
-    expected: FAIL
-
-  [margin-bottom: -1.5 (quirks)]
-    expected: FAIL
-
   [margin: -1.5 (quirks)]
     expected: FAIL