fix overflow_y_is_visible()

servo · Nov 6, 2017 · ea3d897 · ea3d897
1 parent 0f5325d
commit ea3d897
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 16 deletions.
diff --git a/components/script/dom/element.rs b/components/script/dom/element.rs
@@ -109,7 +109,8 @@ use style::dom_apis;
 use style::element_state::ElementState;
 use style::invalidation::element::restyle_hints::RestyleHint;
 use style::properties::{Importance, PropertyDeclaration, PropertyDeclarationBlock, parse_style_attribute};
-use style::properties::longhands::{self, background_image, border_spacing, font_family, font_size, overflow_x};
+use style::properties::longhands::{self, background_image, border_spacing, font_family, font_size};
+use style::properties::longhands::{overflow_x, overflow_y};
 use style::rule_tree::CascadeLevel;
 use style::selector_parser::{NonTSPseudoClass, PseudoElement, RestyleDamage, SelectorImpl, SelectorParser};
 use style::selector_parser::extended_filtering;
@@ -373,7 +374,7 @@ impl Element {
     fn overflow_y_is_visible(&self) -> bool {
         let window = window_from_node(self);
         let overflow_pair = window.overflow_query(self.upcast::<Node>().to_trusted_node_address());
-        overflow_pair.y != overflow_x::computed_value::T::visible
+        overflow_pair.y == overflow_y::computed_value::T::visible
     }
 }
 

diff --git a/tests/wpt/metadata/css/css-transforms/css-transforms-3d-on-anonymous-block-001.html.ini b/tests/wpt/metadata/css/css-transforms/css-transforms-3d-on-anonymous-block-001.html.ini
diff --git a/tests/wpt/metadata/css/css-values/vh_not_refreshing_on_chrome.html.ini b/tests/wpt/metadata/css/css-values/vh_not_refreshing_on_chrome.html.ini
diff --git a/tests/wpt/metadata/css/cssom-view/scrolling-quirks-vs-nonquirks.html.ini b/tests/wpt/metadata/css/cssom-view/scrolling-quirks-vs-nonquirks.html.ini
@@ -5,15 +5,6 @@
   [scrollWidth/scrollHeight on the root element in quirks mode]
     expected: FAIL
 
-  [scroll() on the HTML body element in quirks mode]
-    expected: FAIL
-
-  [scrollBy() on the HTML body element in quirks mode]
-    expected: FAIL
-
-  [scrollLeft/scrollTop on the HTML body element in quirks mode]
-    expected: FAIL
-
   [scrollWidth/scrollHeight on the HTML body element in quirks mode]
     expected: FAIL