add comment & add ref test

servo · Jan 21, 2014 · ef122f8 · ef122f8
1 parent 8912df8
commit ef122f8
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 0 deletions.
diff --git a/src/components/main/layout/box_.rs b/src/components/main/layout/box_.rs
@@ -1120,6 +1120,9 @@ impl Box {
                 };
 
 
+                // FIXME(ksh8281): we shouldn't assign height this way
+                // we need box.assign_height
+                // now, we can't know about size of parent's height
                 let height = match (MaybeAuto::from_style(self.style().Box.height,container_width),
                                    image_box_info.dom_height) {
                     (Specified(height),_) => {

diff --git a/src/test/ref/basic.list b/src/test/ref/basic.list
@@ -22,3 +22,4 @@
 == font_size_em.html font_size_em_ref.html
 == font_size_percentage.html font_size_em_ref.html
 == position_fixed_a.html position_fixed_b.html
+== img_size_a.html img_size_b.html
diff --git a/src/test/ref/img_size.png b/src/test/ref/img_size.png
diff --git a/src/test/ref/img_size_a.html b/src/test/ref/img_size_a.html
@@ -0,0 +1,18 @@
+<html>
+    <head>
+        <title>
+            The winter is too cold for me...
+        </title>
+    </head>
+    <body>
+        <div>
+            <img src="img_size.png" width="206" />
+        </div>
+        <div>
+            <img src="img_size.png" width="206" />
+        </div>
+        <div style="width:1000px">
+            <img src="img_size.png" style="width:100px" />
+        </div>
+    </body>
+</html>
diff --git a/src/test/ref/img_size_b.html b/src/test/ref/img_size_b.html
@@ -0,0 +1,18 @@
+<html>
+    <head>
+        <title>
+            The winter is too cold for me...
+        </title>
+    </head>
+    <body>
+        <div>
+            <img src="img_size.png" height="206" />
+        </div>
+        <div>
+            <img src="img_size.png" style="height:206px"/>
+        </div>
+        <div style="width:1000px">
+            <img src="img_size.png" style="width:10%" />
+        </div>
+    </body>
+</html>