style: Don't apply text-combine-upright in sideways-* writing modes.

Differential Revision: https://phabricator.services.mozilla.com/D61326
servo · Feb 12, 2020 · f426b64 · f426b64
1 parent 6682f72
commit f426b64
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/components/style/style_adjuster.rs b/components/style/style_adjuster.rs
@@ -281,7 +281,7 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
         let writing_mode = self.style.get_inherited_box().clone_writing_mode();
         let text_combine_upright = self.style.get_inherited_text().clone_text_combine_upright();
 
-        if writing_mode != WritingMode::HorizontalTb &&
+        if matches!(writing_mode, WritingMode::VerticalRl | WritingMode::VerticalLr) &&
             text_combine_upright == TextCombineUpright::All
         {
             self.style.add_flags(ComputedValueFlags::IS_TEXT_COMBINED);