Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix concatentation error on no args to
./mach rustc
Since default argument to params is None, concatenating it with a list will raise an error. This behaviour prevents `./mach rustc` to be called when system-rust is defined in .servobuild. Currently it will only work when followed by an argument, i.e. `./mach rustc -arg`. Testing this patch: `./mach rustc` should not raise an error.
- Loading branch information
f716e8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from metajack
at https://github.com/andreastt/servo/commit/f716e8bbf1f20e280d5f973664fd3b4fc91686de
f716e8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging andreastt/servo/ato/concat_error_on_system_rust = f716e8b into auto
f716e8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
andreastt/servo/ato/concat_error_on_system_rust = f716e8b merged ok, testing candidate = 35c13f0
f716e8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://build.servo.org/builders/linux1/builds/214
success: http://build.servo.org/builders/linux2/builds/214
success: http://build.servo.org/builders/android/builds/281
success: http://build.servo.org/builders/mac1/builds/431
success: http://build.servo.org/builders/mac2/builds/431
f716e8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 35c13f0