Skip to content

Commit

Permalink
This commit refactors shiftKey to shift_key where possible.
Browse files Browse the repository at this point in the history
  • Loading branch information
bubbles231 committed Sep 18, 2016
1 parent 77170a1 commit fd0622a
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions components/script/dom/activation.rs
Expand Up @@ -63,7 +63,7 @@ pub enum ActivationSource {
// https://html.spec.whatwg.org/multipage/#run-synthetic-click-activation-steps
pub fn synthetic_click_activation(element: &Element,
ctrl_key: bool,
shiftKey: bool,
shift_key: bool,
altKey: bool,
metaKey: bool,
source: ActivationSource) {
Expand Down Expand Up @@ -94,7 +94,7 @@ pub fn synthetic_click_activation(element: &Element,
0,
0,
ctrl_key,
shiftKey,
shift_key,
altKey,
metaKey,
0,
Expand Down
2 changes: 1 addition & 1 deletion components/script/dom/htmlanchorelement.rs
Expand Up @@ -540,7 +540,7 @@ impl Activatable for HTMLAnchorElement {
}

//TODO:https://html.spec.whatwg.org/multipage/#the-a-element
fn implicit_submission(&self, _ctrl_key: bool, _shiftKey: bool, _altKey: bool, _metaKey: bool) {
fn implicit_submission(&self, _ctrl_key: bool, _shift_key: bool, _altKey: bool, _metaKey: bool) {
}
}

Expand Down
4 changes: 2 additions & 2 deletions components/script/dom/htmlbuttonelement.rs
Expand Up @@ -283,7 +283,7 @@ impl Activatable for HTMLButtonElement {

// https://html.spec.whatwg.org/multipage/#implicit-submission
#[allow(unsafe_code)]
fn implicit_submission(&self, ctrl_key: bool, shiftKey: bool, altKey: bool, metaKey: bool) {
fn implicit_submission(&self, ctrl_key: bool, shift_key: bool, altKey: bool, metaKey: bool) {
let doc = document_from_node(self);
let node = doc.upcast::<Node>();
let owner = self.form_owner();
Expand All @@ -295,7 +295,7 @@ impl Activatable for HTMLButtonElement {
.find(|r| r.form_owner() == owner)
.map(|s| synthetic_click_activation(s.r().as_element(),
ctrl_key,
shiftKey,
shift_key,
altKey,
metaKey,
ActivationSource::NotFromClick));
Expand Down
4 changes: 2 additions & 2 deletions components/script/dom/htmlinputelement.rs
Expand Up @@ -1275,7 +1275,7 @@ impl Activatable for HTMLInputElement {

// https://html.spec.whatwg.org/multipage/#implicit-submission
#[allow(unsafe_code)]
fn implicit_submission(&self, ctrl_key: bool, shiftKey: bool, altKey: bool, metaKey: bool) {
fn implicit_submission(&self, ctrl_key: bool, shift_key: bool, altKey: bool, metaKey: bool) {
let doc = document_from_node(self);
let node = doc.upcast::<Node>();
let owner = self.form_owner();
Expand All @@ -1296,7 +1296,7 @@ impl Activatable for HTMLInputElement {
if button.is_instance_activatable() {
synthetic_click_activation(button.as_element(),
ctrl_key,
shiftKey,
shift_key,
altKey,
metaKey,
ActivationSource::NotFromClick)
Expand Down
2 changes: 1 addition & 1 deletion components/script/dom/htmllabelelement.rs
Expand Up @@ -76,7 +76,7 @@ impl Activatable for HTMLLabelElement {
}

// https://html.spec.whatwg.org/multipage/#implicit-submission
fn implicit_submission(&self, _ctrl_key: bool, _shiftKey: bool, _altKey: bool, _metaKey: bool) {
fn implicit_submission(&self, _ctrl_key: bool, _shift_key: bool, _altKey: bool, _metaKey: bool) {
//FIXME: Investigate and implement implicit submission for label elements
// Issue filed at https://github.com/servo/servo/issues/8263
}
Expand Down
4 changes: 2 additions & 2 deletions components/script/dom/touchevent.rs
Expand Up @@ -64,7 +64,7 @@ impl TouchEvent {
target_touches: &TouchList,
ctrl_key: bool,
altKey: bool,
shiftKey: bool,
shift_key: bool,
metaKey: bool) -> Root<TouchEvent> {
let ev = TouchEvent::new_uninitialized(window, touches, changed_touches, target_touches);
ev.upcast::<UIEvent>().InitUIEvent(type_,
Expand All @@ -73,7 +73,7 @@ impl TouchEvent {
view, detail);
ev.ctrl_key.set(ctrl_key);
ev.alt_key.set(altKey);
ev.shift_key.set(shiftKey);
ev.shift_key.set(shift_key);
ev.meta_key.set(metaKey);
ev
}
Expand Down

0 comments on commit fd0622a

Please sign in to comment.