Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability on dependency (ecdsa), not planned to be fixed #341

Open
Merinorus opened this issue Jan 24, 2024 · 8 comments
Open

Vulnerability on dependency (ecdsa), not planned to be fixed #341

Merinorus opened this issue Jan 24, 2024 · 8 comments

Comments

@Merinorus
Copy link

Hello,

The ecdsa package is a requirement for this project. There is a vulnerability affecting the latest version (0.18.0), but the maintainers don't plan to fix it.
More information here: GHSA-wj6h-64fc-37mp

@Merinorus Merinorus changed the title Vulnerability on dependency, not planned to be fixed (ecdsa) Vulnerability on dependency (ecdsa), not planned to be fixed Jan 24, 2024
@syntaxaire
Copy link

syntaxaire commented Jan 24, 2024

I was also brought here by security alerts this morning.

From the python-ecdsa security policy, which the maintainers cite in their reply:

This library was not designed with security in mind. If you are processing data that needs to be protected we suggest you use a quality wrapper around OpenSSL.

So I would ask, what is it being used for in this project?

Edit: It seems this repository is abandoned (#332). The solution is to get away from python-jose as a dependency. My team's requirements are met by PyJWT which is 4x more popular (by stars) but has 5x fewer open issues.

@JonasKs
Copy link

JonasKs commented Jan 30, 2024

So I would ask, what is it being used for in this project?

This project allow you to use multiple backends, one of them is cryptography, as is the solution suggested solution.

It’s all there, in the README: https://github.com/mpdavis/python-jose?tab=readme-ov-file#cryptographic-backends

In other words, ensure you’re using the cryptography backend. You can also uninstall the ecdsa library, even though it’s unused when using the cryptography backend.

@lsmith77
Copy link

lsmith77 commented Feb 2, 2024

guess it makes more sense to just migrate to https://github.com/jpadilla/pyjwt

@yaronbenezra
Copy link

hello,

The dependence on this library on ecdsa exposes us to several attacks :

ecdsa Missing Encryption of Sensitive Data [CVSS 7.4]
and also ecdsa Timing Attack [CVE-2024-23342]

The ECDSA is not maintained and not built for production:
https://github.com/tlsfuzzer/python-ecdsa

Why you are still using it, can you please dispose of it?

I think if you continue to use them you also need to add the following note to your project:

" NOTE: This library should not be used in production settings, see Security for more details."

please help the world to be a safer

@JonasKs
Copy link

JonasKs commented Feb 15, 2024

@yaronbenezra , did you even read my reply?

@mathieuruellanmyscript
Copy link

mathieuruellanmyscript commented Feb 15, 2024

Perhaps a stupid question: If it works with other backends, why not removing ecdsa backend?

@lsmith77
Copy link

The package is not maintained, so no changes can be done to it.

@jpmckinney
Copy link

Anyone know how to replace jose's jwk.construct when using PyJWT?

I documented other migration steps at jpadilla/pyjwt#942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants