Fix 19021 17630 #138
Merged
Fix 19021 17630 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heuchi
pushed a commit
to heuchi/MuseScore
that referenced
this pull request
Nov 13, 2013
Fix 19021 17630
Xmader
added a commit
to Xmader/MuseScore
that referenced
this pull request
Aug 19, 2021
Merge pull request musescore#138 from Xmader/dependabot/npm_and_yarn/path-parse-1.0.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong direction of broken beam segment in {longer-dotted note + shorter note} groups.
See issue tracker: http://musescore.org/en/node/19021 and http://musescore.org/en/node/17360
The code is shorter and simpler than the initial proposal in the issue tracker itself. The fix passed all the tests I could think of, but it also seems 'too simple to be true', then I am NOT going to merge it until someone of the core developers reviews and approves it.