Fix #11073 #731
Merged
Fix #11073 #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this issue gomesrod and for the PR. In order to accept PR's, MuseScore contributors are requested to sign the CLA: http://musescore.org/en/cla You haven't signed yet, so please do so first. Thanks. |
|
Thanks for the information Thomas. I have signed the CLA. |
|
yet again the travis failure doesn't seem to be related to the PR at all |
lasconic
added a commit
that referenced
this pull request
Mar 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://musescore.org/en/node/11073
The Score::deleteItem() implementation already does that: after deleting a note from a chord, another note - specifically the chord->downNote() - should be automatically selected.
But later in the Score::cmdDeleteSelection() method all the selection was cleared, unless the user is in Note Entry mode. I don't know what was the intention of this block of code, but removing it solves the bug and (as far as I can tell) there is no negative side-effect.