Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with getSumScroll Function while dragging the item using drag handle or by moving the item #900

Open
Nikhil1489 opened this issue Feb 7, 2023 · 0 comments

Comments

@Nikhil1489
Copy link

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch react-calendar-timeline@0.28.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-calendar-timeline/lib/lib/utility/dom-helpers.js b/node_modules/react-calendar-timeline/lib/lib/utility/dom-helpers.js
index 4637dbc..313aa25 100644
--- a/node_modules/react-calendar-timeline/lib/lib/utility/dom-helpers.js
+++ b/node_modules/react-calendar-timeline/lib/lib/utility/dom-helpers.js
@@ -32,7 +32,7 @@ function getParentPosition(element) {
 }
 
 function getSumScroll(node) {
-  if (node === document.body) {
+  if (node === document.body || !node.parentNode) {
     return {
       scrollLeft: 0,
       scrollTop: 0

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant