Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use post-compile views in checks #1131

Merged
merged 2 commits into from Mar 20, 2017
Merged

Use post-compile views in checks #1131

merged 2 commits into from Mar 20, 2017

Conversation

denisdefreyne
Copy link
Member

@denisdefreyne denisdefreyne commented Mar 20, 2017 •
edited

Fixes #1130.

There are three different view contexts in Nanoc:

  1. Preprocess: reps do not exist
  2. Compilation: reps exist; accessing data might create dependencies
  3. Postprocess: reps exist, accessing data will not create dependencies

The checks should use the postprocess views, rather than the compilation views.

@denisdefreyne denisdefreyne added this to the 4.7.2 milestone Mar 20, 2017
@denisdefreyne denisdefreyne merged commit c12fe42 into master Mar 20, 2017
@denisdefreyne denisdefreyne deleted the gh-1130 branch March 20, 2017 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:bug 🐛
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@denisdefreyne