Disallow full identifiers from ending with a slash #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
refuse-full-identifier-ending-with-slash
branch
from
655c981
to
fcdd7e9
Compare
denisdefreyne
force-pushed
the
refuse-full-identifier-ending-with-slash
branch
from
fcdd7e9
to
57fcc9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full identifiers (e.g.
"/foo.md"— compare to legacy identifiers such as"/foo/") can never end with a slash. Nanoc does not currently enforce this, and silently allows a potentially buggy code.This PR makes full identifiers that end with a slash explicitly invalid.
(It turns out that many of the tests cases were accidentally wrong. Yikes!)
This PR also makes
Nanoc::Document#identifier=properly coerce the argument to an identifier, so that@item.identifier = 'hah'no longer turns the identifier from aNanoc::Identifierinto aString.