Add Configuration#dig() and ConfigView#dig() #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpakosz
force-pushed
the
feature/config-dig
branch
from
6bda295
to
fbb8f96
Compare
denisdefreyne
requested changes
Sep 22, 2017
|
|
||
| # @see Hash#dig | ||
| def dig(*keys) | ||
| @context.dependency_tracker.bounce(unwrap, attributes: keys) |
There was a problem hiding this comment.
attributes is a list of top-level attributes that are touched, so this should be keys.first instead. Nanoc only tracks dependencies of keys one level deep.
(keys will also work, but generate unnecessary dependencies.)
|
|
||
| context 'with non-existing keys' do | ||
| let(:keys) { %i[foo baz bar] } | ||
| it { is_expected.to eql(nil) } |
There was a problem hiding this comment.
Prefer be_nil over eql(nil)
|
I’ve applied the changes and merged it into master! Thanks for the quick contribution! |
|
Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting closer to winning your eternal gratitude 😄