Require bundler so that Bundler::GemfileNotFound becomes available

[denisdefreyne]

Without requiring bundler, Bundler::GemfileNotFound does not exist.

Sorry for the delay in fixing this. :(

CC @bobthecow @gpakosz @jugglinmike - 👍 if you like (picking some random people to review)

[coveralls]

Coverage increased (+0.2%) when pulling 5b21655 on require-bundler-for-gemfile-not-found-error into f859105 on release-3.7.x.

[gpakosz]

👍

[bobthecow]

lgtm 👍

[FredyFreshFirm]

Ok
20. juli 2014 18:18 skrev "Justin Hileman" notifications@github.com
følgende:

lgtm [image: 👍]

—
Reply to this email directly or view it on GitHub
#464 (comment).

[jugglinmike]

I verified this manually, but I'm wondering if we can back this with a test. test/test_gem.rb seems a likely candidate. It probably requires a lot more infrastructure than that file provides (we'd have to temporarily move this project's own Gemfile).

It's likely more appropriate to open a separate issue to create tests for nanoc's executable. Does this seem like a good idea?

[FredyFreshFirm]

Yup

Fredy Otén
22. juli 2014 14:23 skrev "jugglinmike" notifications@github.com følgende:

I verified this manually, but I'm wondering if we can back this with a
test. test/test_gem.rb
https://github.com/nanoc/nanoc/blob/db1db138608d4f6786e1a2482f12ab20359b424c/test/test_gem.rb
seems a likely candidate. It probably requires a lot more infrastructure
than that file provides (we'd have to temporarily move this project's own
Gemfile).

It's likely more appropriate to open a separate issue to create tests for
nanoc's executable. Does this seem like a good idea?

—
Reply to this email directly or view it on GitHub
#464 (comment).

[denisdefreyne]

@jugglinmike The problem is that we already use Bundler to run the tests, which means bundler is already required. bin/nanoc is not tested except manually.

[jugglinmike]

Our dependence on Bundler is no problem for testing this change--it just needs to ensure that the executable functions correctly in the absence of a Gemfile. But I don't mean to bikeshed; you should open a dedicated issue if you think that's worthwhile.

[denisdefreyne]

@jugglinmike It’s very hard to test properly because it depends on the gems you have installed. You’d need to have a way of automatically testing with different gem setups (no Bundler + no Gemfile, no Bundler + Gemfile, Bundler + no Gemfile, Bundler + Gemfile).