Ensure layouts are truely textual #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to change file extension for layouts files created in tests. |
|
👍 |
| @@ -93,6 +93,8 @@ def load_objects(dir_name, kind, klass) | |||
| if is_binary && klass == Nanoc::Item | |||
| meta = (meta_filename && YAML.load_file(meta_filename)) || {} | |||
| content_or_filename = content_filename | |||
| elsif is_binary && klass == Nanoc::Layout | |||
| raise "The file '#{content_filename}' is a binary file. The 'layouts/' directory should contain only true textual layouts." | |||
There was a problem hiding this comment.
Not entirely sure about the wording here. What about:
The layout file '#{content_filename}' is a binary file, but layouts can only be textual.
|
Looks good apart from my remark. |
|
Changed the wording. |
denisdefreyne
added a commit
that referenced
this pull request
Aug 17, 2014
Ensure layouts are truely textual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a
RuntimeErrorwhen binary files are found in thelayouts/directory. Addresses #457.