Improve Nanoc::Int::ItemArray #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An item collection is not inherently an array (it is not ordered). The API now reflects this.
denisdefreyne
force-pushed
the
fix-item-array
branch
from
719ebb6
to
5b92c4b
Compare
denisdefreyne
added a commit
that referenced
this pull request
May 15, 2015
Improve Nanoc::Int::ItemArray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nanoc::Int::ItemArrayis icky (too array-like, with too much magic delegation). This improves ItemArray to be more in line with the API thatItemCollectionViewexposes.From the public API point of view, only the removal of
#at,#[]returning an array, and integer indexing has changed.Future work could include renaming
ItemArraytoItemCollection, but for the sake of not diverging too much from 3.x, I’ll keep it this way for now.