Fix using #compiled_content in layout #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
allow-compiled-content-in-layout
branch
from
2af6da0
to
d66741d
Compare
|
@gjtorikian This is the proper fix. |
denisdefreyne
added a commit
that referenced
this pull request
Dec 12, 2015
Fix using #compiled_content in layout
|
Confirmed fixed in 4.1.0rc1. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
@item.compiled_contentin a layout broke in 4.1.0a1. This was caused by#compiled_contentsearching for the first snapshot with a given name (in this case,:pre) rather than the last one.I’ve created a separate regression test in
spec/nanoc/regressions. I haven’t done something like this before, but it seems sensible.Fixes #761.