Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler warnings / errors from new logging feature on Windows #1825

Closed
shikokuchuo opened this issue Apr 24, 2024 · 2 comments
Closed

Compiler warnings / errors from new logging feature on Windows #1825

shikokuchuo opened this issue Apr 24, 2024 · 2 comments

Comments

@shikokuchuo
Copy link
Contributor

Describe the bug

  1. Compiler warns of unused variable in win_clock.c
  2. Some Windows platforms do not have timespec_get (MinGW) so we should test for it like on POSIX, and provide an alternative, or have an option to disable logging entirely.

** Environment Details **

  • NNG 1.8.0
  • Various Windows build machines
  • GNU 10.4.0 under MinGW
  • Static Lib

Additional context
(1) is an easy fix and I'll provide a PR.
(2) as I do not make use of logging, I can live with a CMake check and compile time define - but others may want something that works.
@shikokuchuo shikokuchuo mentioned this issue Apr 24, 2024
Closed
@gdamore
Copy link
Contributor

gdamore commented Apr 25, 2024

Argh. MinGW again. I fricking hate that because it misses a lot of real Windows APIs. This one now too.

In the past I've said that I don't support it. I'm not sure what to do here. This needs to be at least a warning.

@gdamore
Copy link
Contributor

gdamore commented May 22, 2024

So apparently MinGW-w64 has a timespec_get API if you use the Universal C Runtime (UCRT). The default legacy MSVCRT is lacking, and I have no interest in wasting my time with it.

gdamore added a commit that referenced this issue May 22, 2024
@gdamore
fixes #1825 Compiler warning due to unused variable in win_clock.c
6e907ce
gdamore added a commit that referenced this issue May 22, 2024
@gdamore
fixes #1825 Compiler warning due to unused variable in win_clock.c
b7a0227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1825 Compiler warnings / errors from new logging feature on Window shikokuchuo/nng
2 participants
@gdamore @shikokuchuo