Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version published to crates.io #43

Open
xd009642 opened this issue Mar 31, 2022 · 3 comments
Open

version published to crates.io #43

xd009642 opened this issue Mar 31, 2022 · 3 comments

Comments

@xd009642
Copy link

Can there be a version published for use within Rust code, as well as existing python and wasm versions? Seems a bit unfortunate some colleagues can use this in their python projects but I need to fork it to use it in Rust to remove the crate-type cdylib etc.

@davidatsurge
Copy link

davidatsurge commented Jul 11, 2022

Alongside this, if the maintainers think it's a good idea, I would be happy to look into making the functions exposed from the rust crate generic over the type of the alphabet (right now, the alphabet must be a String).

I'm doing this already in a local copy of the repo because I'm using this library to decode output from an ASR model, and the network output is a distribution over WordPiece tokens (which are not necessarily one letter characters).

@iiSeymour
Copy link
Member

I'm very happy to upstream improvements.

@davidatsurge
Copy link

Sounds good. I'm also looking into adding language model support because I need it, so it will take me a while before I submit even the "expose-a-rust-API-and-make-it-generic" feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants