Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty groups tests #82

Open
nathaneastwood opened this issue Feb 14, 2021 · 3 comments
Open

Fix empty groups tests #82

nathaneastwood opened this issue Feb 14, 2021 · 3 comments
Assignees
@nathaneastwood
Labels
question Further information is requested

Comments

@nathaneastwood
Copy link
Owner

nathaneastwood commented Feb 14, 2021 •
edited

See inst/tinytest/test_empty_groups.R.
@nathaneastwood nathaneastwood added the bug Something isn't working label Feb 14, 2021
@nathaneastwood nathaneastwood added this to the 0.2.5 milestone Feb 14, 2021
@nathaneastwood nathaneastwood self-assigned this Mar 1, 2021
@nathaneastwood nathaneastwood added question Further information is requested and removed bug Something isn't working labels Mar 28, 2021
@nathaneastwood
Copy link
Owner Author

I am pausing the work on this until I get an answer to: https://twitter.com/nathaneastwood_/status/1376145804705021959?s=20

@nathaneastwood
Copy link
Owner Author

nathaneastwood commented Mar 28, 2021 •
edited

More information: https://stackoverflow.com/questions/66840953/how-does-dplyr-handle-empty-groups-when-displaying-groups-attribute

@nathaneastwood nathaneastwood removed this from the 0.2.5 milestone Mar 28, 2021
@nathaneastwood nathaneastwood mentioned this issue Mar 28, 2021
Closed
@nathaneastwood
Copy link
Owner Author

It would appear that the groups are created by recursively splitting: tidyverse/dplyr#5830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathaneastwood nathaneastwood

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathaneastwood