Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic types aren't universally recognized #5

Open
mdorf opened this issue Mar 21, 2019 · 2 comments
Open

Semantic types aren't universally recognized #5

mdorf opened this issue Mar 21, 2019 · 2 comments

Comments

@mdorf
Copy link
Member

mdorf commented Mar 21, 2019

Per user report:

I have been experimenting with the annotator found here:
https://bioportal.bioontology.org/annotator

Settings:
Text entered into annotator: invasive mammary carcinoma
Select ontology: National Cancer Institute Thesaurus (NCIT)
Select UMLS semantic type: neoplastic process

Result: no annotations found

I am not understanding why the result is 'No annotations found'. The term 'invasive mammary carcinoma' does exist in the NCIT, with semantic_type 'Neoplastic process'.

https://bioportal.bioontology.org/ontologies/NCIT?p=classes&conceptid=http%3A%2F%2Fncicb.nci.nih.gov%2Fxml%2Fowl%2FEVS%2FThesaurus.owl%23C9245

@mdorf
Copy link
Member Author

mdorf commented Mar 21, 2019

Our logic for annotating semantic types looks for a property of the class that contains the semantic type code (T191 in this case). Once found, the value is used to set a custom top-level property of the class called “semanticType”. The value of the “semanticType” property is then used when we process classes for the Annotator repository. Looking at the class you provided, there is no property in the class that references the semantic type code. There is one that states the name of the semantic type, “Neoplastic Process”, but that isn’t sufficient for us to classify this as a class belonging to the T191 semantic type:

http://data.bioontology.org/ontologies/NCIT/classes/http%3A%2F%2Fncicb.nci.nih.gov%2Fxml%2Fowl%2FEVS%2FThesaurus.owl%23C9245?display=all&no_links=true&no_context=true

Here is a sample of a different class from SNOMEDCT that does set the semantic type property and thus appears in your annotation query (if you remove the NCIT ontology filter):

http://data.bioontology.org/ontologies/SNOMEDCT/classes/http%3A%2F%2Fpurl.bioontology.org%2Fontology%2FSNOMEDCT%2F68453008?display=all&no_links=true&no_context=true

@mdorf mdorf self-assigned this Mar 21, 2019
@graybeal graybeal changed the title Symantic types aren't universally recognized Semantic types aren't universally recognized May 13, 2019
@graybeal
Copy link

I'm making this a "won't fix", as we are not doing anything wrong per Misha's analysis.

@graybeal graybeal reopened this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants