Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result sets include classes that no longer exist in latest submission #7

Open
jvendetti opened this issue Oct 3, 2019 · 0 comments
Labels

Comments

@jvendetti
Copy link
Member

To reproduce, execute the following REST call that includes ancestors specified to 3 levels deep:

http://data.bioontology.org/annotator?text=Melanoma%20is%20a%20malignant%20tumor%20of%20melanocytes%20which%20are%20found%20predominantly%20in%20skin%20but%20also%20in%20the%20bowel%20and%20the%20eye.&ontologies=MEDLINEPLUS&expand_class_hierarchy=true&class_hierarchy_max_level=3

In the resulting JSON, there's one ancestral annotatedClass object with distance of 2 that no longer exists in the latest submission of the MEDLINEPLUS ontology. Screenshot of particular result:

Screenshot 2019-10-03 14 40 03

Clicking on the "self" link results in a 404 error:

"Resource 'http://purl.bioontology.org/ontology/MEDLINEPLUS/C1456590' not found in ontology MEDLINEPLUS submission 13"

@alexskr performed a full regeneration of the Annotator cache for all ontologies on Oct. 2nd. I checked the log file on the production parsing box (/srv/ncbo/ncbo_cron/logs/cache.log) and see no errors for the MEDLINEPLUS ontology:

I, [2019-10-02T22:08:06.271420 #22045]  INFO -- : Creating Annotator cache for http://data.bioontology.org/ontologies/MEDLINEPLUS (http://data.bioontology.org/ontologies/MEDLINEPLUS/submissions/13) - 1142/1238 ontologies
I, [2019-10-02T22:08:06.333339 #22045]  INFO -- : ["Caching classes of MEDLINEPLUS"]
I, [2019-10-02T22:08:07.448444 #22045]  INFO -- : ["Page 1 of 1 - 2258 classes retrieved in 1.110196227 sec."]
I, [2019-10-02T22:08:20.611879 #22045]  INFO -- : ["Page 1 of 1 cached in Annotator in 13.163305221 sec."]
I, [2019-10-02T22:08:20.703788 #22045]  INFO -- : ["Completed caching ontology: MEDLINEPLUS (http://data.bioontology.org/ontologies/MEDLINEPLUS/submissions/13) in 14.278680390212685 sec. 2258 classes."]

A side effect of this issue is that our example code for working with the Annotator throws exceptions - so far noticed by at least one end user (see: ncbo/ncbo_rest_sample_code#5)

@jvendetti jvendetti added the bug label Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant