Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use transition hook API instead of state change events #182

Open
p0lar-bear opened this issue Jun 29, 2017 · 0 comments
Open

Update to use transition hook API instead of state change events #182

p0lar-bear opened this issue Jun 29, 2017 · 0 comments

Comments

@p0lar-bear
Copy link

p0lar-bear commented Jun 29, 2017

As I said in #159:

Also, I think it's prudent to call attention to the fact that these state change events were deprecated with ui-router v1.0. The ui-router team has provided polyfills for them, and while this is a valid stopgap, this breadcrumb module should be updated to use the transition hook API instead of these events.

If I can find the time I could look into making these changes myself, I'll do so and submit a pull request, but at the moment my hands are tied and can't do much more than call attention to and whine about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant