Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'showAbstractStates' varible to $$options #28

Closed
guytish opened this issue Jul 5, 2014 · 3 comments
Closed

Add 'showAbstractStates' varible to $$options #28

guytish opened this issue Jul 5, 2014 · 3 comments

Comments

@guytish
Copy link

guytish commented Jul 5, 2014

It will be very nice to expose this to the configuration.
Abstract states should not be clickable as same as current state.

@ncuillery
Copy link
Owner

It seems possible. The only question I ask is: Is it useful ?

Have you faced a context where such an option could have been used ?

@guytish
Copy link
Author

guytish commented Jul 5, 2014

From my end, I think it's very useful.
I believe you need to expose as much as possible for more powerfull and generic module.

@ncuillery
Copy link
Owner

With this option set to true, a breadcrumb could look like that:

Home / Clickable state / Unclickable state / Another state / Last state

I have never seen a breadcrumb like this...

Moreover, you can already customize the breadcrumb by using an external template (if you want a breadcrumb starting with an unclickable label for example).

My primary objective is to protect the consistency of the module, not to make it working with every twisted situations.

Feel free to tell me I'm wrong by giving me an example where such an option is useful.

ncuillery added a commit that referenced this issue Oct 22, 2014
The global option `includeAbstract` can be used to include
abstract states in the chain of states.

Those states are displayed in the breadcrumb with a
span (they can't be accessed).

Closes #35, #28
ncuillery added a commit that referenced this issue Oct 23, 2014
The global option `includeAbstract` can be used to include
abstract states in the chain of states.

Those states are displayed in the breadcrumb with a
span (they can't be accessed).

Closes #35, #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants