Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncyBreadcrumbParent substitution #46

Closed
migajek opened this issue Oct 8, 2014 · 3 comments
Closed

ncyBreadcrumbParent substitution #46

migajek opened this issue Oct 8, 2014 · 3 comments
Assignees
@ncuillery
Labels
enhancement
Milestone
0.3.0

Comments

@migajek
Copy link

migajek commented Oct 8, 2014

Hi, would it be possible to use substitution when providing ncyBreadcrumbParent ?
The "parent" I want to provide has some obligatory url parameter.
I'd like it to have like this:

data: {
    ncyBreadcrumbParent: 'projects({group: currentProject.groupId})',
    ncyBreadcrumbLabel: 'Project {{ currentProject.name  }}'
}
@ncuillery
Copy link
Owner

Hi,

It's not possible for the moment, but I am thinking seriously to add this feature in the next version 0.3.0.

I like the syntax you have provided (the same as ui-sref).

I keep the issue open.

Thanks for reporting.

@migajek
Copy link
Author

migajek commented Oct 12, 2014

thanks for the response, I'll keep watching

@ncuillery ncuillery added this to the 0.3.0 milestone Oct 15, 2014
@ncuillery ncuillery self-assigned this Oct 15, 2014
ncuillery added a commit that referenced this issue Oct 15, 2014
@ncuillery
feat($breadcrumb): Support url params when using `ncyBreadcrumb.paren…
5573004 
…t` property

The state-specific option `ncyBreadcrumb.parent` supports now url params.
It allows specifying parent with the same syntax as the UI-router's
`ui-sref` either with a string value or with a function value :
```
ncyBreadcrumb: {
  parent: 'contact.detail({idContact: 42})'
}
```

The option prefixStateName have also the same syntax.

Closes #46
@ncuillery
Copy link
Owner

Landed on v0.3.x

Pending the release, you can download the 0.3.x branch with bower by doing this:
bower install angular-breadcrumb#v0.3.x

ncuillery added a commit that referenced this issue Oct 15, 2014
@ncuillery
chore(sample): Add an other way to access to the room.detail state
6dad6d6 
The `room.detail` can be accessed via the `room` state and the
`booking.day` state by clicking on the room number in the list of
reservations.

It demonstrates the ability to reference a parent state with url params (#46).
ncuillery added a commit that referenced this issue Oct 16, 2014
@ncuillery
test: Add test case for url params when using ncyBreadcrumb.parent
d3c6e98 
Related to #46
@ncuillery ncuillery mentioned this issue Oct 19, 2014
Closed
ncuillery added a commit that referenced this issue Oct 31, 2014
@ncuillery
chore(sample): Add an other way to access to the room.detail state
2f9d564 
The `room.detail` can be accessed via the `room` state and the
`booking.day` state by clicking on the room number in the list of
reservations.

It demonstrates the ability to reference a parent state with url params (#46).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncuillery ncuillery

Labels
enhancement
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@migajek @ncuillery