-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First implementation to display multilingual email parts (RFC8255) #1104
Conversation
Written during the #IETFHackathon [1] of the #IETF101 [2]. [1] : https://trac.ietf.org/trac/ietf/meeting/wiki/101hackathon [2] : https://www.ietf.org/how/meetings/101/ This code is **not stable** nor **correct** regarding to the neomutt code style / contribution guide. This just demonstrated the Proof Of Concept to display in a MUA email build with RFC8255. **Use at your own risk.** A RFC8255 reflector has also be developped during the #IETFHackathon, see here : https://github.com/igit/rfc8255-reflector
Thanks for the code @igit -- very interesting.
hehe, not a problem. It would be really helpful if you could attach a sample email for us to test. |
@flatcap Maybe examples from RFC8255 could be sufficient for testing https://trac.tools.ietf.org/html/rfc8255#section-8 + @igit has a repo https://github.com/igit/rfc8255-reflector which could be quite useful for testing too. |
@flatcap @jindraj Thank you guys for regarding this code ! Please let's me know if it (the reflector) works fine for you. |
Congratulations, this is great work. What about one or two screenshots for the poeple who hesitate to try the patch? |
9436309
to
131aabb
Compare
I've given it a try and it works (you knew that :-) I've run the code through Your code looks reasonable. I still have more testing to do. Your code reads the multi-lingual parts. |
How do you get those emoji displayed in the pager? |
This series of patches look good to me. I will add support for writing multipart/multilingual emails in branch https://github.com/neomutt/neomutt/tree/devel/multipartalternative |
@flatcap @igit Can I apply the patch to branch [devel/multipartalternative] so that I can directly develop on that branch?. All the commit messages will be leave intact (it seems like a rebase). Also, there is a bug in viewing the multilingual message: when there is no |
Merged as part of #734 |
Written during the #IETFHackathon [1] of the #IETF101 [2].
[1] : https://trac.ietf.org/trac/ietf/meeting/wiki/101hackathon
[2] : https://www.ietf.org/how/meetings/101/
This code is not stable nor correct regarding to the neomutt code style / contribution guide.
This just demonstrated the Proof Of Concept to display in a MUA email build with RFC8255.