Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal 0.25.0 and Kemal 0.23.0 breaks kemal-flash #2

Open
lebogan opened this issue Jun 20, 2018 · 0 comments
Open

Crystal 0.25.0 and Kemal 0.23.0 breaks kemal-flash #2

lebogan opened this issue Jun 20, 2018 · 0 comments

Comments

@lebogan
Copy link

lebogan commented Jun 20, 2018

Kemal-flash doesn't seem to keep flash on redirect. I forked, updated the shards, and ran spec and got this:

Failures:

  1) Kemal::Flash should handle updates to flash
     Failure/Error: response.body.should eq("{\"values\":{\"lucy\":\"linus\"},\"discard\":[]}")

       Expected: "{\"values\":{\"lucy\":\"linus\"},\"discard\":[]}"
            got: "{\"values\":{},\"discard\":[]}"

     # spec/kemal-flash_spec.cr:20

  2) Kemal::Flash should keep flash on a redirect
     Failure/Error: response.body.should eq("302")

       Expected: "302"
            got: ""

     # spec/kemal-flash_spec.cr:25

Finished in 5.43 milliseconds
14 examples, 2 failures, 0 errors, 0 pending

Failed examples:

crystal spec spec/kemal-flash_spec.cr:15 # Kemal::Flash should handle updates to flash
crystal spec spec/kemal-flash_spec.cr:23 # Kemal::Flash should keep flash on a redirect

Are you still maintaining this shard? If so, although I'm not a developer, I would like to help. This is too cool a project to let languish, imho.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant