Adds support for exponential notation like 1e10 => 10000000000 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
reviewed
Dec 19, 2022
Comment on lines
+247
to
+250
| while let Some(next) = chars.peek() { | ||
| if !matches!(*next, '0'..='9') { | ||
| break; | ||
| } |
There was a problem hiding this comment.
This can use .next_if instead.
pickfire
reviewed
Dec 19, 2022
|
|
||
| if num_vec.len() > 0 { | ||
| if let Some(exp) = num_vec.parse::<usize>().ok() { | ||
| result.push(Token::Num(x * pow(10 as f64, exp) as f64)); |
There was a problem hiding this comment.
Wouldn't using num::pow directly be better?
Suggested change
| result.push(Token::Num(x * pow(10 as f64, exp) as f64)); | |
| result.push(Token::Num(x * num::pow(10 as f64, exp) as f64)); |
pickfire
reviewed
Dec 19, 2022
| chars.next(); | ||
| } | ||
|
|
||
| if num_vec.len() > 0 { |
There was a problem hiding this comment.
Suggested change
| if num_vec.len() > 0 { | |
| if !num_vec.is_empty() { |
pickfire
reviewed
Dec 19, 2022
Comment on lines
+290
to
+294
| #[test] | ||
| fn eval_exponential_notation_decimal() { | ||
| let evaled = eval("2.5e5", None); | ||
| assert_eq!(evaled, Ok(250000.0)); | ||
| } |
There was a problem hiding this comment.
Can you please try this too? 5e5e5.
|
@dannyvankooten Any updates on this? |
|
@AmeerTaweel I think you can just create a PR to supersede this pull request, the author might be busy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68