Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rack Elevation links should not target _blank #3943

Closed
ktims opened this issue Jan 17, 2020 · 0 comments
Closed

Rack Elevation links should not target _blank #3943

ktims opened this issue Jan 17, 2020 · 0 comments
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@ktims
Copy link

ktims commented Jan 17, 2020

Environment

  • Python version: 3.6.7
  • NetBox version: 2.7.0

Proposed Functionality

Rack elevation links should not set the target attribute to _blank, so users can choose whether a new tab/window should be opened or not.

Use Case

There is no way to suppress target="_blank" when clicking links in the browser, however there are well known and easy ways to open new tabs or windows if desired. The default should not be to override normal browser behaviour, and should match the treatment of links throughout the rest of the Netbox UI.

Database Changes

N/A

External Dependencies

N/A
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application labels Jan 17, 2020
@jeremystretch jeremystretch mentioned this issue Jan 17, 2020
Merged
kobayashi pushed a commit to kobayashi/netbox that referenced this issue Jan 17, 2020
@jeremystretch @kobayashi
Fixes netbox-community#3943: Prevent rack elevation links from openin…
cd7d0cd 
…g new tabs/windows
@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktims @jeremystretch